Skip to content

Move observe before truncate in FitnessEliminator #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HyperCodec merged 2 commits into from
Feb 23, 2026
Merged

Move observe before truncate in FitnessEliminator #132

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7615002
Initial plan
Copilot Feb 23, 2026
9343fc4
move observe call before truncate in FitnessEliminator
Copilot Feb 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions genetic-rs-common/src/builtin/eliminator.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,17 +186,17 @@ where
fn eliminate(&self, genomes: Vec<G>) -> Vec<G> {
let mut fitnesses = self.calculate_and_sort(genomes);
let median_index = (fitnesses.len() as f32) * self.threshold;
fitnesses.truncate(median_index as usize + 1);
self.observer.observe(&fitnesses);
fitnesses.truncate(median_index as usize + 1);
fitnesses.into_iter().map(|(g, _)| g).collect()
}

#[cfg(feature = "rayon")]
fn eliminate(&self, genomes: Vec<G>) -> Vec<G> {
let mut fitnesses = self.calculate_and_sort(genomes);
let median_index = (fitnesses.len() as f32) * self.threshold;
fitnesses.truncate(median_index as usize + 1);
self.observer.observe(&fitnesses);
fitnesses.truncate(median_index as usize + 1);
fitnesses.into_par_iter().map(|(g, _)| g).collect()
}
}
Expand Down