Bot: replace static "Thinking..." with rotating typing indicator#63
Closed
Dhereal1 wants to merge 25 commits intoHyperlinksSpace:mainfrom
Closed
Bot: replace static "Thinking..." with rotating typing indicator#63Dhereal1 wants to merge 25 commits intoHyperlinksSpace:mainfrom
Dhereal1 wants to merge 25 commits intoHyperlinksSpace:mainfrom
Conversation
…add regression test
Contributor
Author
|
Closes #62 |
Member
|
Many unnessesary file's changes. Should be a tiny PR to app/bot/reponder.ts mainly. We already have handler.ts functionality in app/bot/responder.ts and app/ai/transmitter.ts. Webhook is already ok, fatal error on unsuccessful setup is normal. Bot.py was switched to TS implementation, strange you still commit to that file. I see a lack of understanding of what is happening. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace static "Thinking..." with rotating typing indicator
This PR implements the animated placeholder for the bot typing state.
Instead of a static
"Thinking...", the bot now cycles:Thinking.
Thinking..
Thinking...
The animation runs until the first AI response is ready, then immediately stops so the real response replaces the placeholder without delay.
Changes
bot/bot.pybot/tests/test_typing_indicator.pyVerification
python -m py_compilepasses