Prescaler was not initialized in init#584
Merged
jorgesg82 merged 12 commits intodevelopmentfrom Mar 4, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the encoder timer initialization to ensure the timer prescaler/period are applied during Encoder::init, addressing the reported issue that the prescaler was not initialized.
Changes:
- Removes configuration of
TIM_HandleTypeDef::Initfields insideEncoder::init. - Adds direct writes to the timer registers (
PSC,ARR) after HAL encoder/master initialization.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
victor-Lopez25
previously approved these changes
Mar 4, 2026
Contributor
victor-Lopez25
left a comment
victor-Lopez25
left a comment
There was a problem hiding this comment.
I made this change and I think I did very good
…PV-H8/ST-LIB into fix/encoder_prescaler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.