feat: add datepicker as a fragment component#262
Open
Conversation
Signed-off-by: Max You <max.you@outlook.com>
✅ Deploy Preview for carbon-components-builder ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
zvonimirfras
requested changes
Sep 7, 2023
Member
zvonimirfras
left a comment
zvonimirfras
left a comment
There was a problem hiding this comment.
- Shouldn't be able to take focus and type inside in the editor.
- Date format doesn't seem to be reflected correctly from config.
- Range looks broken when label is set
- "Date picker range start" and "end" feel misleading
- Exporting undefined seems pointless, also defining empty strings when they are default shouldn't be a thing in export
- This is also wrong?
- size in angular export is incorrectly applied
- angular export doesn't follow the same pattern as other angular exports, when it comes to inputs
- type "text" is not a thing in datepicker afaik
etc...
Signed-off-by: Max You <max.you@outlook.com>
Signed-off-by: Max You <max.you@outlook.com>
Signed-off-by: Max You <max.you@outlook.com>
Signed-off-by: Max You <max.you@outlook.com>
Signed-off-by: Max You <max.you@outlook.com>
Signed-off-by: Max You <max.you@outlook.com>
Signed-off-by: Max You <max.you@outlook.com>
Signed-off-by: Max You <max.you@outlook.com>
Signed-off-by: Max You <max.you@outlook.com>
zvonimirfras
requested changes
Jan 4, 2024
| sendSignal(state.id, 'valueChange', [event[0].toISOString()], { ...state, value: event[0].toISOString() }); | ||
| }}> | ||
| <DatePickerInput | ||
| id={`${state.id} + '-start'`} |
Member
There was a problem hiding this comment.
We don't need the "-start", do we?
Contributor
Author
There was a problem hiding this comment.
yes, we need something to differentiate the start date and end date if type is selecting a date range instead of a single date
| datePickerType={componentObj.datePickerType} | ||
| light={componentObj.light}> | ||
| <DatePickerInput | ||
| id={`${componentObj.id} + '-start'`} |
Contributor
Author
There was a problem hiding this comment.
yes, this is the date range selection
Comment on lines
+189
to
+193
| placeholder: 'mm/dd/yyyy', | ||
| size: 'md', | ||
| datePickerType: 'simple', | ||
| dateFormat: 'm/d/Y', | ||
| rangeStartLabel: 'Start Label' |
Member
There was a problem hiding this comment.
Do we need all these? 'Start Label' feels wrong
Contributor
Author
There was a problem hiding this comment.
yes, we need it to select a date range (eg., start and end date)
| imports: ['DatePicker', 'DatePickerInput'], | ||
| code: ({ json }) => { | ||
| return `<DatePicker | ||
| ${reactClassNamesFromComponentObj(json)} |
Member
There was a problem hiding this comment.
Indentation for this block looks wrong...
Contributor
Author
There was a problem hiding this comment.
This is weird, in local it looks fine
| imports: ['DatePicker', 'DatePickerInput'], | ||
| code: ({ json }) => { | ||
| return `<DatePicker | ||
| ${reactClassNamesFromComponentObj(json)} |
Member
There was a problem hiding this comment.
block indentation looks off
Contributor
Author
There was a problem hiding this comment.
same thing, in local, it looks fine
Signed-off-by: Max You <max.you@outlook.com>
Signed-off-by: Max You <JianzhongMax.You@ibm.com>
Contributor
Author
|
Verified that the component features and export works. |
Signed-off-by: Akshat Patel <akshat@live.ca>
Signed-off-by: Akshat Patel <akshat@live.ca>
Signed-off-by: Akshat Patel <akshat@live.ca>
Signed-off-by: Max You <JianzhongMax.You@ibm.com>
jz5426
commented
May 29, 2024
Signed-off-by: Akshat Patel <akshat@live.ca>
Signed-off-by: Akshat Patel <akshat@live.ca>
Signed-off-by: Akshat Patel <akshat@live.ca>
Signed-off-by: Max You <JianzhongMax.You@ibm.com>
Signed-off-by: Max You <JianzhongMax.You@ibm.com>
zvonimirfras
requested changes
Jul 16, 2024
Member
zvonimirfras
left a comment
zvonimirfras
left a comment
There was a problem hiding this comment.
- linting errors
- indentation and ternaries
Comment on lines
+98
to
+110
| const componentAttributes = selectedComponent; | ||
|
|
||
| if (!checked) { | ||
| // Deleting the attributes from the model | ||
| delete componentAttributes.rangePlaceholder; | ||
| } else { | ||
| // Restore user set range placeholder | ||
| componentAttributes.rangePlaceholder = rangePlaceholder; | ||
| } | ||
|
|
||
| setComponent({ | ||
| ...componentAttributes | ||
| }); |
Member
There was a problem hiding this comment.
There needs to be a better way to do what you're trying to do.
Contributor
Author
There was a problem hiding this comment.
note: spread the operator and only set the rangePlaceholder
added 3 commits
July 23, 2024 11:54
Signed-off-by: Max You <JianzhongMax.You@ibm.com>
Signed-off-by: Max You <JianzhongMax.You@ibm.com>
Signed-off-by: Max You <JianzhongMax.You@ibm.com>
jz5426
commented
Jul 25, 2024
|
|
||
| export interface DatePickerState { | ||
| type: string; | ||
| placeholder: string; |
added 2 commits
July 25, 2024 14:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for #131