feat: Add timepicker component by jz5426 · Pull Request #299 · IBM/carbon-ui-builder

jz5426 · 2024-02-01T13:00:55Z

netlify · 2024-02-01T13:00:59Z

✅ Deploy Preview for carbon-components-builder ready!

Name	Link
🔨 Latest commit	`0d89669`
🔍 Latest deploy log	https://app.netlify.com/projects/carbon-components-builder/deploys/66a174c7a9ba5e0008461e0f
😎 Deploy Preview	https://deploy-preview-299--carbon-components-builder.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Signed-off-by: Max You <max.you@outlook.com>

Signed-off-by: Zvonimir Fras <zvonimir@zvonimirfras.com> Signed-off-by: Max You <max.you@outlook.com>

* chore: migrate nx to the latest version Signed-off-by: Akshat Patel <akshat@live.ca> * chore: update base branch Signed-off-by: Akshat Patel <akshat@live.ca> * chore: centralize linting rules in root Signed-off-by: Akshat Patel <akshat@live.ca> * chore: update lib project name to match supported framework Signed-off-by: Akshat Patel <akshat@live.ca> * chore: remove overrides Signed-off-by: Akshat Patel <akshat@live.ca> * chore: lint fix Signed-off-by: Akshat Patel <akshat@live.ca> * chore: lint fix Signed-off-by: Akshat Patel <akshat@live.ca> * chore: disable caching for lint results Signed-off-by: Akshat Patel <akshat@live.ca> * chore: update lint fix script Signed-off-by: Akshat Patel <akshat@live.ca> --------- Signed-off-by: Akshat Patel <akshat@live.ca> Signed-off-by: Max You <max.you@outlook.com>

Signed-off-by: Zvonimir Fras <zvonimir@zvonimirfras.com> Signed-off-by: Max You <max.you@outlook.com>

* chore: update build directory names and path Signed-off-by: Akshat Patel <akshat@live.ca> * chore: lint fix Signed-off-by: Akshat Patel <akshat@live.ca> * chore: update project source root Signed-off-by: Akshat Patel <akshat@live.ca> * chore: Set output path for libs in dist/libs/* Signed-off-by: Akshat Patel <akshat@live.ca> * chore: Add nx release script Signed-off-by: Akshat Patel <akshat@live.ca> * ci: Add publish ci flow Signed-off-by: Akshat Patel <akshat@live.ca> * chore: Add SemVer versioning Signed-off-by: Akshat Patel <akshat@live.ca> * chore: add commintlint Signed-off-by: Akshat Patel <akshat@live.ca> * chore: add root workspace Signed-off-by: Akshat Patel <akshat@live.ca> * Support {{children}} in custom components Signed-off-by: Zvonimir Fras <zvonimir@zvonimirfras.com> Signed-off-by: Akshat Patel <akshat@live.ca> * Fix export template not working when items empty Signed-off-by: Zvonimir Fras <zvonimir@zvonimirfras.com> Signed-off-by: Akshat Patel <akshat@live.ca> * chore: publish without packing Signed-off-by: Akshat Patel <akshat@live.ca> * revert: file deletion Signed-off-by: Akshat Patel <akshat@live.ca> * chore: give execute permissions Signed-off-by: Akshat Patel <akshat@live.ca> * chore: use carbon bot for publishing github releases Signed-off-by: Akshat Patel <akshat@live.ca> * chore: skip app commit types Signed-off-by: Akshat Patel <akshat@live.ca> * chore: add �pp as an acceptable commit type Signed-off-by: Akshat Patel <akshat@live.ca> * chore: update secret name Signed-off-by: Akshat Patel <akshat@live.ca> * ci: migrate back to workflow Signed-off-by: Akshat Patel <akshat@live.ca> --------- Signed-off-by: Akshat Patel <akshat@live.ca> Signed-off-by: Zvonimir Fras <zvonimir@zvonimirfras.com> Co-authored-by: Zvonimir Fras <zvonimir@zvonimirfras.com> Signed-off-by: Max You <max.you@outlook.com>

Signed-off-by: Akshat Patel <akshat@live.ca> Signed-off-by: Max You <max.you@outlook.com>

Signed-off-by: Zvonimir Fras <zvonimir@zvonimirfras.com> Signed-off-by: Max You <max.you@outlook.com>

Signed-off-by: Max You <max.you@outlook.com>

src/customComponents.json

sdk/react/src/lib/fragment-components/a-time-picker.tsx

player/react/src/lib/components/ui-time-picker.tsx

Signed-off-by: Max You <max.you@outlook.com>

src/customComponents.json

sdk/react/src/lib/fragment-components/a-time-picker.tsx

Signed-off-by: Max You <max.you@outlook.com>

Co-authored-by: Akshat Patel <38994122+Akshat55@users.noreply.github.com>

sdk/react/src/lib/fragment-components/a-time-picker.tsx

Signed-off-by: Max You <JianzhongMax.You@ibm.com>

jz5426 · 2024-04-25T16:00:46Z

Verified that the component features and export works.

Signed-off-by: Max You <JianzhongMax.You@ibm.com>

Akshat55

Time picker timezones do not show up for react because timezone does not exist.

sdk/react/src/lib/fragment-components/a-time-picker.tsx

…timepicker

Signed-off-by: Max You <JianzhongMax.You@ibm.com>

fix: conditionally render time picker select in export and give user control to render Signed-off-by: Akshat Patel <akshat@live.ca>

Signed-off-by: Akshat Patel <akshat@live.ca>

Signed-off-by: Max You <JianzhongMax.You@ibm.com>

zvonimirfras · 2024-07-16T09:58:17Z

player/react/src/lib/components/ui-time-picker.tsx

+	...commonSlots,
+	...slotsDisabled,
+	invalid: 'boolean',
+	isInvalid: (state: TimePickerState) => ({


They should be setters and follow function naming e.g. setInvalid
Plus, setInvalid seems like it would do the same thing as invalid property, so it's not necessary?

note: date picker seems to be doing the naming right

i think the naming of the setter is fine, i don't think other component (i,e. combobox) use this naming. setInvalid is fine but no need for unnecessary changes.

In terms of the need of setInvalid, please check combobox as well because the setter is similar.

player/react/src/lib/components/ui-time-picker.tsx

sdk/react/src/lib/fragment-components/a-time-picker.tsx

zvonimirfras · 2024-07-16T10:10:08Z

sdk/react/src/lib/fragment-components/a-time-picker.tsx

+				selected: false
+			}
+		],
+		value: '',


empty value?

what is wrong with empty value?

sdk/react/src/lib/fragment-components/a-time-picker.tsx

zvonimirfras · 2024-07-16T10:25:41Z

sdk/react/src/lib/fragment-components/a-time-picker.tsx

+			}
+		],
+		value: '',
+		timezones: []


there is no default timezone values so i make it empty initially

sdk/react/src/lib/fragment-components/a-time-picker.tsx

player/react/src/lib/components/ui-time-picker.tsx

Co-authored-by: Zvonimir Fras <zvonimir.fras@gmail.com>

Signed-off-by: Max You <JianzhongMax.You@ibm.com>

jz5426 and others added 17 commits February 1, 2024 08:01

custom components

7c87efd

Signed-off-by: Max You <max.you@outlook.com>

Restore export modal tab order between opens

61655a6

Signed-off-by: Zvonimir Fras <zvonimir@zvonimirfras.com> Signed-off-by: Max You <max.you@outlook.com>

Support {{children}} in custom components

11e53cd

Signed-off-by: Zvonimir Fras <zvonimir@zvonimirfras.com> Signed-off-by: Max You <max.you@outlook.com>

Fix export template not working when items empty

9c2984b

Signed-off-by: Zvonimir Fras <zvonimir@zvonimirfras.com> Signed-off-by: Max You <max.you@outlook.com>

fix: remove nx set sha action (IBM#293)

e080e1d

Signed-off-by: Akshat Patel <akshat@live.ca> Signed-off-by: Max You <max.you@outlook.com>

fix: add release config (IBM#294)

ea419ca

Signed-off-by: Akshat Patel <akshat@live.ca> Signed-off-by: Max You <max.you@outlook.com>

fix: add permission for id-token (IBM#295)

6eeac0a

Signed-off-by: Akshat Patel <akshat@live.ca> Signed-off-by: Max You <max.you@outlook.com>

fix: add repository url to packages (IBM#296)

8728221

Signed-off-by: Akshat Patel <akshat@live.ca> Signed-off-by: Max You <max.you@outlook.com>

Add instructions to set up a new project w/ player

4a72a08

Signed-off-by: Zvonimir Fras <zvonimir@zvonimirfras.com> Signed-off-by: Max You <max.you@outlook.com>

Fix export error when custom collections undefined

d7523d3

Signed-off-by: Zvonimir Fras <zvonimir@zvonimirfras.com> Signed-off-by: Max You <max.you@outlook.com>

Fix export error when custom collections undefined

6fc2a14

Signed-off-by: Zvonimir Fras <zvonimir@zvonimirfras.com> Signed-off-by: Max You <max.you@outlook.com>

draft

5200b0c

Signed-off-by: Max You <max.you@outlook.com>

draft

300f3bd

Signed-off-by: Max You <max.you@outlook.com>

svg timepicker

5ff39dd

Signed-off-by: Max You <max.you@outlook.com>

timpicker

69a994f

Signed-off-by: Max You <max.you@outlook.com>

jz5426 force-pushed the timepicker branch from afcc2be to 69a994f Compare February 1, 2024 13:01

conflict

9d30222

Signed-off-by: Max You <max.you@outlook.com>

Akshat55 requested changes Feb 8, 2024

View reviewed changes

jz5426 added 5 commits February 14, 2024 21:24

progress

83e7732

Signed-off-by: Max You <max.you@outlook.com>

double quote to singlel quote

1860d51

Signed-off-by: Max You <max.you@outlook.com>

double quote to singlel quote

68087b2

Signed-off-by: Max You <max.you@outlook.com>

slots

f915cd8

Signed-off-by: Max You <max.you@outlook.com>

build error

f32c890

Signed-off-by: Max You <max.you@outlook.com>

Akshat55 requested changes Feb 16, 2024

View reviewed changes

jz5426 and others added 3 commits February 21, 2024 19:52

delete custom compo

314db02

Signed-off-by: Max You <max.you@outlook.com>

Update sdk/react/src/lib/fragment-components/a-time-picker.tsx

d738613

Co-authored-by: Akshat Patel <38994122+Akshat55@users.noreply.github.com>

Update sdk/react/src/lib/fragment-components/a-time-picker.tsx

ad8bd29

Co-authored-by: Akshat Patel <38994122+Akshat55@users.noreply.github.com>

Akshat55 requested changes Mar 27, 2024

View reviewed changes

sdk/react/src/lib/fragment-components/a-time-picker.tsx Outdated Show resolved Hide resolved

Max You added 2 commits March 27, 2024 12:10

done

3010c06

Signed-off-by: Max You <JianzhongMax.You@ibm.com>

fix export

446c530

Signed-off-by: Max You <JianzhongMax.You@ibm.com>

fix action

26dc9c2

Signed-off-by: Max You <JianzhongMax.You@ibm.com>

Akshat55 requested changes May 2, 2024

View reviewed changes

sdk/react/src/lib/fragment-components/a-time-picker.tsx Outdated Show resolved Hide resolved

sdk/react/src/lib/fragment-components/a-time-picker.tsx Outdated Show resolved Hide resolved

Akshat55 approved these changes May 2, 2024

View reviewed changes

zvonimirfras reviewed May 3, 2024

View reviewed changes

sdk/react/src/lib/fragment-components/a-time-picker.tsx Outdated Show resolved Hide resolved

Max You added 2 commits May 3, 2024 15:54

Merge branch 'main' of https://github.com/IBM/carbon-ui-builder into …

c2d1736

…timepicker

lint

86864e5

Signed-off-by: Max You <JianzhongMax.You@ibm.com>

jz5426 force-pushed the timepicker branch from 29c1fb9 to 86864e5 Compare May 3, 2024 19:55

Akshat55 and others added 11 commits May 9, 2024 22:57

chore: lint fix

666b1bb

fix: conditionally render time picker select in export and give user control to render Signed-off-by: Akshat Patel <akshat@live.ca>

chore: lint exports

54bcf0a

Signed-off-by: Akshat Patel <akshat@live.ca>

fix: remove redundant attribute from interface

56c4a16

fix: correct export conditions

286b536

Signed-off-by: Akshat Patel <akshat@live.ca>

fix: add missing events in export

3000eb1

Signed-off-by: Akshat Patel <akshat@live.ca>

fixed angular export

da19cbd

Signed-off-by: Max You <JianzhongMax.You@ibm.com>

angular export

528347f

Signed-off-by: Max You <JianzhongMax.You@ibm.com>

resolve conflict

8793f16

Signed-off-by: Max You <JianzhongMax.You@ibm.com>

angular export fix

9bf08e3

Signed-off-by: Max You <JianzhongMax.You@ibm.com>

fix react export import section

cb7d011

Signed-off-by: Max You <JianzhongMax.You@ibm.com>

Merge branch 'main' into timepicker

d906675

zvonimirfras requested changes Jul 16, 2024

View reviewed changes

jz5426 and others added 7 commits July 22, 2024 15:41

Update player/react/src/lib/components/ui-time-picker.tsx

b0608e3

Co-authored-by: Zvonimir Fras <zvonimir.fras@gmail.com>

Update player/react/src/lib/components/ui-time-picker.tsx

3378c01

Co-authored-by: Zvonimir Fras <zvonimir.fras@gmail.com>

Update sdk/react/src/lib/fragment-components/a-time-picker.tsx

6bf50b8

Co-authored-by: Zvonimir Fras <zvonimir.fras@gmail.com>

revision

50e59e1

Signed-off-by: Max You <JianzhongMax.You@ibm.com>

revision

fe4c0fe

Signed-off-by: Max You <JianzhongMax.You@ibm.com>

revision

d605326

Signed-off-by: Max You <JianzhongMax.You@ibm.com>

style

0d89669

Signed-off-by: Max You <JianzhongMax.You@ibm.com>

Conversation

jz5426 commented Feb 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Feb 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for carbon-components-builder ready!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jz5426 commented Apr 25, 2024

Uh oh!

Akshat55 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zvonimirfras Jul 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jz5426 Jul 22, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zvonimirfras Jul 16, 2024

Choose a reason for hiding this comment

Uh oh!

jz5426 Jul 22, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

zvonimirfras Jul 16, 2024

Choose a reason for hiding this comment

Uh oh!

jz5426 Jul 22, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jz5426 commented Feb 1, 2024 •

edited

Loading

netlify bot commented Feb 1, 2024 •

edited

Loading

zvonimirfras Jul 16, 2024 •

edited

Loading