Updating cloud-init config files and base image by adarshagrawal38 · Pull Request #24 · IBM/project-pim

adarshagrawal38 · 2025-09-05T09:44:01Z

No description provided.

dharaneeshvrd

We have to update the bootstrap iso as well, since the logic there is to read from sr dev and look for exact file names of 99_network_config.cfg.
Also did you tested this in IBMi env?

adarshagrawal38 · 2025-09-08T05:16:50Z

We have to update the bootstrap iso as well, since the logic there is to read from sr dev and look for exact file names of 99_network_config.cfg. Also did you tested this in IBMi env?

Yes I tested PR in IBMI env, new cloud-init is working as expected.

dharaneeshvrd · 2025-09-08T09:11:31Z

I was facing the issue that I talked about can you please take a look at the getconfig systemd log in bootstrap process? We have to fix that.

adarshagrawal38 · 2025-09-18T06:19:22Z

I was facing the issue that I talked about can you please take a look at the getconfig systemd log in bootstrap process? We have to fix that.

@dharaneeshvrd this issue will be solved when we create bootstrap.iso with new steps, here is the new bootstrap iso file is kept which is used for testing -> http://9.114.99.227/fedora41-bootc-bootstrap.iso

dharaneeshvrd

@adarshagrawal38
I think PartOf config will start all the systemd at the same time, but what we want is hierarichal start, I think that can be achieved by Requires and After config itself.
We just need to configure them properly such that each level depends on the previous level. Example if you take hmc-agent, agent and server services should be started only after vllm is started, all three services should not be started at the same time.
Can you please take a look at that? Also monitor the start time of the services that it follows one after the other.

manju956 · 2025-10-15T09:21:32Z

base-image/base_config.sh

-
-echo "base_config.sh run successfully!"
-
+echo "base_config.sh run successfully!"


what is the purpose of this script? It doesn't do any operations rt?

yeah will remove this script.

please rename base_config to appropriate one like root_pim or something like that, it should denote that this act as a base service for all the systemd services that are getting installed as part of PIM

re-naming it as pim_init.service

manju956 · 2025-10-15T09:22:27Z

cli/cloud-init-iso/templates/network-config

@@ -0,0 +1,10 @@
+version: 2


should we keep the file with suffix .cfg as kept earlier?

In one of the solution I saw keeping network related information in network-config loads network for the machine.

I can try changing file name to network-config.cfg and see if it work. I think cfg extension is added for custom config

sure, keep whichever works.

manju956 · 2025-10-15T09:24:14Z

cli/cloud-init-iso/templates/user-data

+users:
+  - name: {{ config["ssh"]["user-name"] }}
+    sudo: ['ALL=(ALL) NOPASSWD:ALL']
+    lock_passwd: true


what does this cfg do?

Config is for loading user and ssh keys in the LPAR.

no, i asked about lock_passwd.

is used to disable password login for pim user

manju956 · 2025-10-21T05:19:58Z

cli/cloud-init-iso/templates/network-config

+    gateway4: {{ config["partition"]["network"]["ip"]["gateway"] }}
+    nameservers:
+      addresses:
+        - {{ config["partition"]["network"]["ip"]["nameserver"] }}


Add new line EOF

manju956 · 2025-10-21T07:35:15Z

base-image/base_config.service


 [Install]
-WantedBy=cloud-config.target
+WantedBy=cloud-config.target


Add newline here as well

Signed-off-by: Adarsh Agrawal <adarsh.agrawal1@ibm.com>

dharaneeshvrd

Also we have to document that the user should follow the hierarchical structure we are following to keep the application grouped. Maybe in examples/README.md or builder-guide.md. Please explain it with the hmc-agent example itself.

dharaneeshvrd · 2025-10-21T14:25:14Z

base-image/Containerfile


-RUN systemctl unmask base_config.service
-RUN systemctl enable base_config.service
+RUN systemctl unmask pim_init.service


I think its better to align with the image name, base-service

kept it as base.service

dharaneeshvrd · 2025-10-21T14:26:23Z

base-image/base.service

@@ -5,7 +5,7 @@ Wants=network-online.target cloud-config.target

 [Service]
 Type=oneshot
-ExecStart=/usr/bin/env /bin/bash /usr/bin/base_config.sh
+ExecStart=/bin/true


Let's print some logs, so that we can get the timestamp in journalctl log, not sure just true would give anything in journalctl

added one liner log

dharaneeshvrd · 2025-10-22T13:45:19Z

cli/cmd/update_config.py

+            logger.error(f"failed to restart base.service. error: {errorMsg}")
+            raise Exception(errorMsg)

+        os.remove(f"{common.cloud_init_update_config_dir}/pim_config.json")


Why are you removing this before moving to the common.cloud_init_config_dir that's happening below?

removing it before otherwise pim_config.json will be packaged in cloud-init.iso
when we trigger launch after update-config.

pim_config.json is of no use in cloud-int.iso

dharaneeshvrd · 2025-10-22T13:46:21Z

cli/utils/iso_util.py

+        auth_data = json.loads(auth_json)
+        auth_json = json.dumps(auth_data, separators=(',', ':'))


why this is required?

auth json is in multiple line, which results in alignment breaking when we load auth.json in user-data template.

In this 2 line we are converting multi to a single line json

dharaneeshvrd · 2025-10-22T13:51:50Z

cli/utils/monitor_util.py

-
-
 def monitor_pim(config):
-    monitor_pim_boot(config)


I think we still need this, by checking the status of base.service, because if user don't want to validate means, there is nothing we are doing as part of monitor_pim method right? So we need some form of verification that upon bootstrap it booted into bootc image and at least started the base.service

okay will add it back

Signed-off-by: Adarsh Agrawal <adarsh.agrawal1@ibm.com>

adarshagrawal38 requested review from dharaneeshvrd and manju956 September 5, 2025 09:44

dharaneeshvrd reviewed Sep 5, 2025

View reviewed changes

adarshagrawal38 force-pushed the cloud-init branch from 99c66be to 0a5daa2 Compare October 7, 2025 16:32

dharaneeshvrd reviewed Oct 15, 2025

View reviewed changes

manju956 reviewed Oct 21, 2025

View reviewed changes

adarshagrawal38 force-pushed the cloud-init branch from 3e78cdc to 772cd4e Compare October 21, 2025 09:42

Updating cloud-init config files, base-image and examples

02f9e44

Signed-off-by: Adarsh Agrawal <adarsh.agrawal1@ibm.com>

adarshagrawal38 force-pushed the cloud-init branch from 772cd4e to 02f9e44 Compare October 21, 2025 09:43

adarshagrawal38 added 2 commits October 21, 2025 17:14

Increase timeout

f00e14d

Signed-off-by: Adarsh Agrawal <adarsh.agrawal1@ibm.com>

Updating service file name

df08495

Signed-off-by: Adarsh Agrawal <adarsh.agrawal1@ibm.com>

dharaneeshvrd reviewed Oct 22, 2025

View reviewed changes

adarshagrawal38 added 2 commits October 23, 2025 01:02

Fixing review comments

d6f4e23

Adding documentation

bbc2fe3

Signed-off-by: Adarsh Agrawal <adarsh.agrawal1@ibm.com>


		echo "base_config.sh run successfully!"

		echo "base_config.sh run successfully!" No newline at end of file

		auth_data = json.loads(auth_json)
		auth_json = json.dumps(auth_data, separators=(',', ':'))

Conversation

adarshagrawal38 commented Sep 5, 2025

Uh oh!

dharaneeshvrd left a comment

Choose a reason for hiding this comment

Uh oh!

adarshagrawal38 commented Sep 8, 2025

Uh oh!

dharaneeshvrd commented Sep 8, 2025

Uh oh!

adarshagrawal38 commented Sep 18, 2025

Uh oh!

dharaneeshvrd left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

manju956 Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

adarshagrawal38 Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dharaneeshvrd left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

manju956 Oct 21, 2025 •

edited

Loading

adarshagrawal38 Oct 21, 2025 •

edited

Loading