Skip to content

(Issue 36) fix IAM token timeout #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mosesevolved wants to merge 2 commits into
base: main
Choose a base branch
from
Open

(Issue 36) fix IAM token timeout #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8d2760
Use token method to manage timeout
MosesMendoza Jul 25, 2021
9aa80c5
Correct use of iat and exp?
MosesMendoza Jul 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/ibm_cloud_sdk_core/authenticators/cp4d_authenticator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ def initialize(vars)

# Adds the Authorization header, if possible
def authenticate(headers)
headers["Authorization"] = "Bearer #{@token_manager.access_token}"
headers["Authorization"] = "Bearer #{@token_manager.token}"
end

# Checks if all the inputs needed are present
Expand Down
2 changes: 1 addition & 1 deletion lib/ibm_cloud_sdk_core/authenticators/iam_authenticator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def initialize(vars)
end

def authenticate(headers)
headers["Authorization"] = "Bearer #{@token_manager.access_token}"
headers["Authorization"] = "Bearer #{@token_manager.token}"
end

def validate
Expand Down
8 changes: 4 additions & 4 deletions test/unit/test_iam_token_manager.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ def test_request_token
"iss": "sss",
"aud": "sss",
"uid": "sss",
"iat": Time.now.to_i + 3600,
"exp": Time.now.to_i
"iat": Time.now.to_i,
"exp": Time.now.to_i + 3600
}
token = JWT.encode token_layout, "secret", "HS256"
response = {
Expand Down Expand Up @@ -108,8 +108,8 @@ def test_get_token
"iss" => "sss",
"aud" => "sss",
"uid" => "sss",
"iat" => 3600,
"exp" => Time.now.to_i
"iat" => Time.now.to_i,
"exp" => Time.now.to_i + 3600
}

access_token = JWT.encode(access_token_layout, "secret", "HS256", "kid": "230498151c214b788dd97f22b85410a5")
Expand Down