Feature: Auth Ready, resolves IBM/unity-sdk-core#32#33
Open
Esam-Bustaty wants to merge 2 commits intoIBM:mainfrom
Open
Feature: Auth Ready, resolves IBM/unity-sdk-core#32#33Esam-Bustaty wants to merge 2 commits intoIBM:mainfrom
Esam-Bustaty wants to merge 2 commits intoIBM:mainfrom
Conversation
…while (!auth.CanAuthenticate)
mamoonraja
reviewed
Jun 16, 2020
Member
mamoonraja
left a comment
There was a problem hiding this comment.
Left one question, overall it does look fine. I will take some time out to do some testing before approving today. Once again thanks a lot for the PR.
|
|
||
| private void OnGetToken(DetailedResponse<CloudPakForDataTokenResponse> response, IBMError error) | ||
| { | ||
| isDoneInitializing = true; |
Member
There was a problem hiding this comment.
Should isDoneInitializing be called after we throw the error?
Contributor
Author
There was a problem hiding this comment.
Well, yes.
If we move the new line a few lines down (inside else statement) so it's not called when an error happens, then there would be no way left for a consumer class to know if an error happened.
If you think this is not clear enough, maybe we should have an IsWaiting field instead, it would have the opposite value to IsDoneInitializing, and maybe makes thing more clear?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
Authenticator.IsDoneInitializingfield socan become: