Conversation
hroumani
left a comment
hroumani
left a comment
There was a problem hiding this comment.
Just a question any reason not to use the versions file like everything else ?
I've added the kafkatag to the json file, i think first time through I was in "developer mode" to reuse/adapt what was there. But I see adding the value to the json it become much more flexible for us when testing an inflight version. |
hroumani
left a comment
hroumani
left a comment
There was a problem hiding this comment.
Looks good !
Just a few questions though.
| "sparkclient": "repo1.maven.org/maven2/com/ibm/event/ibm-db2-eventstore-client-spark-2.4.6/2.0.1.0/ibm-db2-eventstore-client-spark-2.4.6-2.0.1.0.jar", | ||
| "hadoopversion":"2.6", | ||
| "scopt211version":"3.5.0" | ||
| "scopt211version":"3.5.0", |
There was a problem hiding this comment.
I know this was here before but what's this used for ? I didn't see us consuming this for any versioning ?
| "scopt211version":"3.5.0", | ||
| "kafkatag":"v2.0.0.5" | ||
| } , | ||
| "dev" : { |
There was a problem hiding this comment.
What's the idea behind this ? Is it just a placeholder to make it easier for devs to make changes going forward ?
2 participants
basic story requirements futhfilled, will look if we need a subsequent story to expand support for developers using not released versions of ES with Kafka