Conversation
publicJorn
left a comment
There was a problem hiding this comment.
I like that the generated files are now gitignored!
One issue with existing code though: I ran bun run openapi which does stuff. But previous existing code (eg. login-page.tsx) can't find the import that was previously there for the schema.
I think this is because it is looking into components interface instead of operations.
However, it seems that operations is not in type OpenAPIV3.Document.
You know if there was an update in the spec?
16bded6 to
c608812
Compare
publicJorn
left a comment
There was a problem hiding this comment.
Looks mostly good to me!
Only thing I don't really like is that we check for typescript errors really late in the process (because, as we discussed vite needs to build for the .scss.d.ts files to be generated.
On larger projects, it will take some time before it will throw an error, which is a shame.
I'm not sure if there's a way around that.
I tried adding tsc --noEmit to lefthook. But this regenerates the bloody .tsbuildinfo file (which I still don't think we should put under version control, but that's a different discussion) so you will always end up with a change after your commit.
It's not blocking for this PR, but I'd like to discuss this further (maybe with a beer on friday?)
|
Yeah good points. I added the buildinfo to the gitignore as well. As for the checking after building, I'm not sure if there is any way around it unless we unignore the generated files 🙃 |
There are some important features missing from the typegen script.
Notably: