Skip to content

Comments

Heyapi & zod4: 1 - remove zorm#36

Merged
publicJorn merged 4 commits intomainfrom
heyapi-and-zod4/remove-zorm
Feb 10, 2026
Merged

Heyapi & zod4: 1 - remove zorm#36
publicJorn merged 4 commits intomainfrom
heyapi-and-zod4/remove-zorm

Conversation

@publicJorn
Copy link
Member

@publicJorn publicJorn commented Feb 5, 2026

The first PR in a series to upgrade the api generation tool to heyapi (also see #32) and upgrade zod.

Zod is currently a kind of glue, but NONE of the packages that use zod in this project are updated anymore.
Instead of 1 big PR that updates all, to keep it sane I will create multiple smaller PRs.

This first PR does:

  • Remove zorm. For now we do not have client side validation and assume backend validation.
  • In order to keep the number of changes small when we finally choose a new form lib, I have emptied the forgot password page.
  • I have updated the ErrorText component to what we use in Viqio. It handles a string or array of strings.
  • Removed Issues component, which was specific to zod 3.
  • Removed unused translation text.

@publicJorn publicJorn requested a review from maanlamp as a code owner February 5, 2026 14:09
@publicJorn publicJorn self-assigned this Feb 5, 2026
Copy link
Collaborator

@maanlamp maanlamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you install after removing zorm? The build has failed because of an outdated lockfile

@publicJorn
Copy link
Member Author

Did you install after removing zorm? The build has failed because of an outdated lockfile

@maanlamp I guess something went wrong when I split the PRs. Fixed now.

maanlamp
maanlamp previously approved these changes Feb 10, 2026
Copy link
Collaborator

@maanlamp maanlamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, but there are still merge issues

@publicJorn
Copy link
Member Author

Lgtm, but there are still merge issues

yeah, because the styling PR got merged. rebased & fixed. I will merge.

@publicJorn publicJorn merged commit faf5017 into main Feb 10, 2026
1 check passed
@publicJorn publicJorn deleted the heyapi-and-zod4/remove-zorm branch February 10, 2026 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants