fixed Boost::system include for Boost >= 1.89#27
fixed Boost::system include for Boost >= 1.89#27hshose wants to merge 6 commits intoIMRCLab:mainfrom
Conversation
|
Thanks! The CI seems to be broken (again:-/), so it's difficult for me to check if your contribution will break older version (such as boost 1.83 that is still used on Ubuntu), before fixing these issues. Conceptually it makes sense, though and your fix might address the issues the CI finds on Mac OS (not sure what's going on for Windows and Linux, yet). |
|
rebased to current head; attempted vibe-fixing linux and windows CI errors. MacOS CI error on |
|
I bumped the vicon sdk version which might fix the macos CI. I'm a bit lost what is going on with the Windows CI; I vibecoded a bit more to fix the Eigen3 include paths but don't really have a machine or setup to test this on. |
|
This seemed to have gotten it much closer - thanks! |
whoenig
left a comment
whoenig
left a comment
There was a problem hiding this comment.
Generally I am fine with this as it seems to improve things. Would be good if you could test-revert the change outlined below.
|
|
||
| # Add CMAKE_TOOLCHAIN_FILE for vcpkg on Windows | ||
| if "CMAKE_TOOLCHAIN_FILE" in os.environ: | ||
| cmake_args += ["-DCMAKE_TOOLCHAIN_FILE={}".format(os.environ["CMAKE_TOOLCHAIN_FILE"])] | ||
|
|
There was a problem hiding this comment.
Is this actually needed? I think it had no effect in the CI at the end.
|
I have pushed a fixed (partially inspired by your PR - thanks!), see #29. Feel free to open a new PR if you need additional changes (e.g., you enabled newer Python versions). |
2 participants
Issue:
From Boost 1.89 on, the Boost::system library doesn't exist anymore.
Proposed fix:
Replace
Boost::systemwithBoost::boost.Tested with boost 1.89, python 14.