Adding a BIDSification pipeline for an existing patchclamp data set #140
Open
SylvainTakerkart wants to merge 18 commits intoINT-NIT:masterfrom
Open
Adding a BIDSification pipeline for an existing patchclamp data set #140SylvainTakerkart wants to merge 18 commits intoINT-NIT:masterfrom
SylvainTakerkart wants to merge 18 commits intoINT-NIT:masterfrom
Conversation
…d to NW patch clamp data
…generation... To be double checked!
…orks! Next, we have to deal with the autoconversion properly...
Pull Request Test Coverage Report for Build 3641385967
💛 - Coveralls |
…rces as attributes to the class instance
Collaborator
|
@SylvainTakerkart I fixed some error in the CI in master. You might need to merge the new master version here so the tests are passing also in this branch. |
…_sources and organize_data_file to handle the autoconversion properly...
…dentified a bug in BEP032NWDataConverter, to be fixed later...
…eral subjects correctly, with one input tsv file for each subject
Collaborator
|
Hi @SylvainTakerkart I fixed a the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is NOT ready for review! The code is in the state discussed yesterday... I will document it more when I come back from vacation...
But, here is what we decided with @JuliaSprenger yesterday... The current implementation cannot work. What's to be done is:
in the generate_csv_file function, add one column in the csv file, giving the filename (or file directory) where the excel file is
move the read_xls_file so that it is called in the generate_all_metadata function of this specific class (where the instance exists)