[Refactor] Add Subquery e2e + parser/formatter Test #92
+141
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinthebomb1
previously approved these changes
Jan 29, 2026
tests/test_query_parser.py
Outdated
| assert ast == expected_ast | ||
|
|
||
|
|
||
| def test_subqyery_parse(): |
Collaborator
Author
There was a problem hiding this comment.
Thanks for catching it! Fixed
Collaborator
|
The format LGTM! just one small typo |
baiqiushi
previously approved these changes
Feb 3, 2026
tests/test_query_parser.py
Outdated
| assert ast == expected_ast | ||
|
|
||
|
|
||
| def test_subqyery_parse(): |
HazelYuAhiru
dismissed stale reviews from baiqiushi and colinthebomb1
via
bb8723d
colinthebomb1
approved these changes
Feb 4, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
This PR added a subquery test for the parser, formatter, and e2e test.
Code Changes:
test_subqyery_parse,test_subqyery_format, andtest_subquery_e2ein parse, format, and e2e test files.