Conversation
About linking a pull request to an issue@Danbaba1 You want to always link your pull request to the particular issue it addresses. So that one can easily navigate back to the issue. Edit your comment above. Copy what is in the box below and add it in there. This will turn to a link that takes you to the particular issue for this pull request. The issue number is About your branch nameYou can use the name of the task as branch name or any other thing that describes what the branch is for, not your own name. About your codeI left a review comment below. Take a look and add other missing things in your code. |
3.js
Outdated
| @@ -1,13 +1,13 @@ | |||
| export function canExecuteFastAttack(knightIsAwake) { | |||
|
|
|||
| return !KnightIsAwake; | |||
There was a problem hiding this comment.
Since i don't know if it's in one function or all functions, I'm just going to give a "general" review for all the functions.
You didn't include the constants or variables you declared for knightIsAwake and others inside your code. So I don't know if you used true or false value. I don't have super powers to read your mind, nor can I know what you did on exercism.
Which is why I wrote in the instruction that you should replace the content of this file with what you have on exercism.
So remove the entire content of this file and add the exact content you have on exercism - including the variables you declared... include everything. Also let me know which of the functions you have issues with after you have done this.
There was a problem hiding this comment.
i went back to the code after reading your comments and its working now. i changed the const declaration to a var declaration so it ran. thank you ma.
| * @returns {boolean} Whether or not you can send a signal to the prisoner. | ||
| */ | ||
| var archerIsAwake = false; | ||
| var prisonerIsAwake = true; |
There was a problem hiding this comment.
Look at line 16 here. It's supposed be true not false
2 participants
#1