Open
Conversation
added 10 commits
May 2, 2023 13:04
timezone
avfyodorov
reviewed
May 2, 2023
avfyodorov
left a comment
avfyodorov
left a comment
There was a problem hiding this comment.
Добрый вечер, Илья!
Оставил пару комментариев, они на Ваше усмотрение, а так всё в порядке.
gateway/pom.xml
Outdated
There was a problem hiding this comment.
А здесь нужна эта зависимость? Здесь же вроде нет хибернейта...
Не должно быть :-)
There was a problem hiding this comment.
Раз уж оформлено в виде констант, то лучше тогда сделать их совсем глобальными для проекта и вынести в отдельный класс, доступный отовсюду.
added 2 commits
May 2, 2023 20:38
avfyodorov
reviewed
May 2, 2023
avfyodorov
left a comment
avfyodorov
left a comment
There was a problem hiding this comment.
Добрый вечер, Илья!
Замечаний нет.
Работа принята.
Теперь остался диплом, успехов!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1