-
Notifications
You must be signed in to change notification settings - Fork 44
Add clusteringPixelSizeThreshold #363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Here's the code health analysis summary for commits Analysis Summary
|
|
@fedorov I have this solution for items 1 and 2 of #330 (comment). Please let me know if its better now. |
|
|
Now the image doesn't load at all. I deployed using the
|
|
Then we broke the production with another regression... It was working as of Nov 21, 2025, as documented in the screenshot in #330 (comment). |




Clustering Configuration and Progress Indicators
Summary
This PR introduces several enhancements to annotation clustering and processing:
Changes
1. Clustering Pixel Size Threshold (Initial Feature)
Added
clusteringPixelSizeThresholdto component statenumber0.001mm (1 micrometer)SlideViewerStateinterfaceAdded threshold input UI
Updated viewer construction
clusteringPixelSizeThresholdto viewer viaannotationOptionsconstructViewersutility functionAdded
handleClusteringPixelSizeThresholdChangehandler2. Progress Indicator for Bulk Annotations
Added
AnnotationProgresscomponentANNOTATION_PROCESSING_PROGRESSandANNOTATION_RETRIEVAL_PROGRESSeventsIntegrated progress component in SlideViewer
3. UI Toggle for Clustering (Latest Feature)
Added clustering toggle switch in the Annotation Groups menu
SwitchcomponentisClusteringEnabled: true)Conditional display of threshold input
State Management
isClusteringEnabledto component state (type:boolean, default:true)shouldComponentUpdateto include clustering state changesViewer Integration
clusteringPixelSizeThresholdis passed asundefinedto the viewerhandleClusteringTogglehandler with error handling4. Style Updates
Code Quality
/** */)User Experience
Testing
Threshold can be set and updated successfully
Toggle can be switched on/off successfully
Threshold input appears/disappears based on toggle state
Viewer correctly applies clustering settings when toggled
Progress indicator displays during annotation operations
No unnecessary annotation loading when toggling clustering
Works correctly when toggled before annotations are loaded
Bulk annotations always cluster #330 (comment)
DMV PR: Add clusteringPixelSizeThreshold option dicom-microscopy-viewer#222