Skip to content

Conversation

@lyubomirshishkov
Copy link
Collaborator

Description of change

Just updating the Bid Adapter's Documentation as requested in upstream project.

  • adds info available on Prebid.org;
  • improves the styling in some places;
  • adds info about Improve Digital supporting multi-bid.

@jbartek25
Copy link
Member

Hi Lyubo. Appreciate your changes but I'm pretty sure what he meant was updating the main adapter doc https://docs.prebid.org/dev-docs/bidders/improvedigital.html which has source in another repo: https://github.com/ImproveDigital/prebid.github.io/blob/master/dev-docs/bidders/improvedigital.md

@jbartek25
Copy link
Member

while at it, please remove any doc concerning renderer config. Cata removed the code recently but we forgot about the doc.

@lyubomirshishkov
Copy link
Collaborator Author

Alright, I'll make the necessary changes there. As to the ones I made here, should I discard them?

Lastly, do we have a fork for the site, or should I just submit a PR in the main repo https://github.com/prebid/prebid.github.io?

@i-atanasov-az
Copy link

Still good to have the changes here tho

@jbartek25
Copy link
Member

jbartek25 commented Feb 19, 2025

Alright, I'll make the necessary changes there. As to the ones I made here, should I discard them?

The Additional information should be removed. The adapter doc file here is supposed to contain only test ad units and contact details: https://docs.prebid.org/dev-docs/bidder-adaptor.html#bidder-adaptor-Required-Files. However, since you already started updating it, let's use this opportunity to update the test ad units. Remove the current examples and replace them with a banner ad unit 300x250, placement 22135702, publisherId 950 and a video ad unit with placement 22137694 and pub id 950. You can throw in example with keyValues.

Lastly, do we have a fork for the site, or should I just submit a PR in the main repo https://github.com/prebid/prebid.github.io?

The link I provided above is in our fork: https://github.com/ImproveDigital/prebid.github.io/blob/master/dev-docs/bidders/improvedigital.md

@lyubomirshishkov
Copy link
Collaborator Author

@jbartek25 In that case, I'm closing this PR.

lyubomirshishkov pushed a commit that referenced this pull request Jun 3, 2025
…rameters (prebid#13122)

* V 0 29 (prebid#31)

* AGT-403: Add adType parameter to payload in report

* AGT-403: Test for partner report, adType parameter

* AGT-403: Test refactoring

* AGT-403: Documentation updated

* IntentIq Analytics Module: adUnitCode or placemetId to report (#9)

* AGT-446: adUnitCode or placemetId to report

* AGT-446: Description of changes, example

* AGT-446: Fix documentation

* AGT-446: Changes after review

* Agt 409 full url in prebid modules (#8)

* add sync

* update full url

* set url param

* fix comment

* fix issue fix sync mode

* update url

* update full url

* add test

* move browser_blacklist (#10)

* add is optedOut (#11)

* update date in FPD after sync (#12)

* update sync logic for new user (#13)

* fix unit tests

* change version name

* IntentIq ID: Support sourceMetaData and sourceMetaDataExternal (#17)

* AGT-453: Support sourceMetaData

* AGT-453: sourceMetaDataExternal

* AGT-453: Documentation

* AGT-453: Changes after review

* AGT-453: Fix doc

* Fix doc

* AGT-453: Fix test

* update test

* update endpoint (#16)

* update endpoint

* update test

* add tests

* update test

* fix conflict

* fix conflict

* add test for reportingServerAddress

* add test for reportingServerAddress

* AGT-498: support report method parameter (#22)

* AGT-498: reportMethod

* AGT-498: Tests and refactoring

* AGT-498: method refactoring

* AGT-498: get method refactoring

* AGT-498: reportMethod parameter description (#23)

* AGT-498: reportMethod

* AGT-498: Tests and refactoring

* AGT-498: method refactoring

* AGT-498: get method refactoring

* AGT-498: Documentation

* Agt 452 server call counters (#18)

* add counters

* add unit tests and fixes

* counters additions

* clear counters when a request is made

---------

Co-authored-by: Eyvaz Ahmadzada <eyvazahmadzada@gmail.com>

* add siloEnabled feature (#19)

* add siloEnabled feature

* add siloEnabled feature to analytics adapter

* add unit tests for siloEnabled feature

* add siloenabled to docs

---------

Co-authored-by: Eyvaz Ahmadzada <eyvazahmadzada@gmail.com>

* fix unit test issues

* AGT-455: Source parameter in requests (prebid#28)

* AGT-508: Spd parameter (prebid#29)

* AGT-508: Spd parameter

* AGT-508: Move appendSpd to utils

* AGT-499: Support partnerClientIdType and partnerClientId (prebid#30)

* AGT-499: partnerClientId and partnerClientIdType in requests

* AGT-499: Clean comment

* AGT-499: Refactoring

* add groupchanged parameter (#25)

* add groupchanged parameter

* fix md file issue

* add groupChanged example in docs

* remove group from example

* add unit tests and fix groupChanged issue

---------

Co-authored-by: Eyvaz Ahmadzada <eyvazahmadzada@gmail.com>
Co-authored-by: DimaIntentIQ <139111483+DimaIntentIQ@users.noreply.github.com>

* Agt 501 support additional params (#24)

* additionalParams feature init

* additional params add features

* additionalparams fix analytics adapter

* add unit tests for additionalParams

* fix currentBrowser issue

---------

Co-authored-by: Eyvaz Ahmadzada <eyvazahmadzada@gmail.com>
Co-authored-by: DimaIntentIQ <139111483+DimaIntentIQ@users.noreply.github.com>

* fix linter error

---------

Co-authored-by: dmytro-po <dmytro.po@intentiq.com>
Co-authored-by: DimaIntentIQ <139111483+DimaIntentIQ@users.noreply.github.com>
Co-authored-by: dLepetynskyiIntentiq <danylo.le@intentiq.com>
Co-authored-by: DimaIntentIQ <dmytro.piskun@intentiq.com>
Co-authored-by: Eyvaz Ahmadzada <eyvazahmadzada@gmail.com>

* fix unit tests (prebid#32)

Co-authored-by: Eyvaz Ahmadzada <eyvazahmadzada@gmail.com>

* Agt 547 vr bug for module (prebid#33)

* save progress

* fix calling server

* add "dbsaved" parameter

* add tests

* AGT-552: Additional query params (prebid#34)

* AGT-552: Additional query params

* update documentation

---------

Co-authored-by: DimaIntentIQ <dmytro.piskun@intentiq.com>

* Fix unit test for specific browser

* fix spelling

---------

Co-authored-by: Eyvaz <62054743+eyvazahmadzada@users.noreply.github.com>
Co-authored-by: dmytro-po <dmytro.po@intentiq.com>
Co-authored-by: dLepetynskyiIntentiq <danylo.le@intentiq.com>
Co-authored-by: Eyvaz Ahmadzada <eyvazahmadzada@gmail.com>
lyubomirshishkov pushed a commit that referenced this pull request Jun 3, 2025
…ebid 10 (prebid#13194)

* collect EIDs for bid request

* add ad slot positioning to payload

* RPO-2012: Update local storage name-spacing for c_uid (#8)

* Updates c_uid namespacing to be more specific for concert

* fixes unit tests

* remove console.log

* RPO-2012: Add check for shared id (#9)

* Adds check for sharedId

* Updates cookie name

* remove trailing comma

* [RPO-3152] Enable Support for GPP Consent (#12)

* Adds gpp consent integration to concert bid adapter

* Update tests to check for gpp consent string param

* removes user sync endpoint and tests

* updates comment

* cleans up consentAllowsPpid function

* comment fix

* rename variables for clarity

* fixes conditional logic for consent allows function (#13)

* [RPO-3262] Update getUid function to check for pubcid and sharedid (#14)

* Update getUid function to check for pubcid and sharedid

* updates adapter version

* [RPO-3405] Add browserLanguage to request meta object

* ConcertBidAdapter: Add TDID (#20)

* Add tdid to meta object

* Fix null handling and add tests

* Concert Bid Adapter: Add dealId Property to Bid Responses (#22)

* adds dealid property to bid responses

* updates tests

* use first bid for tests

* adds dealid at the correct level

* [RPO-4220] Removes Access to Deprecated userId Object (#23)

* extracts eids

* cleanup

* updates tests and fixes typo

* fix type defs

* use single quotes

* remove whitespace

* bumps adapter version

* removes formatting change

---------

Co-authored-by: antoin <antoin.campbell@voxmedia.com>
Co-authored-by: Antoin <antoinfive@gmail.com>
Co-authored-by: Sam Ghitelman <sam.ghitelman@voxmedia.com>
Co-authored-by: Sam Ghitelman <SGhitelman@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants