This repository was archived by the owner on Apr 7, 2025. It is now read-only.
Add automatic package discovery to composer.json.#10
Open
graham-u wants to merge 1 commit intoIn-Touch:masterfrom
Open
Add automatic package discovery to composer.json.#10graham-u wants to merge 1 commit intoIn-Touch:masterfrom
graham-u wants to merge 1 commit intoIn-Touch:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the README file is states:
...On versions of Laravel less than 5.5, you'll want to register the service provider. Add Intouch\LaravelAwsLambda\LambdaServiceProvider::class, to the providers array in config/app.php.
But as things stand, this is still required in versions 5.5 and above. To enable package auto-discovery in Laravel 5.5 and above, it is required to add an extra section to composer.json so that Laravel can discover and add the service provider to bootstrap/cache/services.php.
This pull request adds the necessary config to composer.json which I have tested locally.
BTW, thanks for your work on this package, this is exactly what i needed.