Open
Conversation
Nandgopal-R
requested review from
SaranHiruthikM and
akshayks13
as code owners
IAmRiteshKoushik
requested changes
Jan 4, 2026
| return | ||
| } | ||
|
|
||
| disputeCount, err := q.CheckDisputeExistsByTxnIdQuery(ctx, tx, txnId) |
Member
There was a problem hiding this comment.
Dispute check must happen before we grabeventIdByTxnId
| return | ||
| } | ||
|
|
||
| studentEmail, err := q.GetEmailByTxnIdQuery(ctx, tx, txnId) |
Member
There was a problem hiding this comment.
Once the dispute check is pushed to the top, the dispute creation flow can happen in a single shot with a sub-query that joins on student table, event table using transaction id and then runs the insert. No need to use separate queries.
| pkg.Log.ErrorCtx(c, "[DISPUTE-ERROR]: Failed to check if dispute exists by transaction ID", err) | ||
| return | ||
| } | ||
| if disputeCount > 0 { |
Member
There was a problem hiding this comment.
Don't send bad request ? Send conflict ? Will it cause issue with the frontend team ?
Member
|
@Nandgopal-R can we clean up the requested changes and then go for a merge ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.