[operations] A new Operations class to enable point-in-element checks from the top level insertion algorithm #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Checks whether a point is inside an element
* Works with an element or a proximity type as input
… class - no dynamic casts to elements
th-skam
added
pr: enhancement
pr: status to review
…insPointInProximity operation
epernod
added
pr: status ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an Operation that enables the
InsertionAlgorithmto use theGenericOperationdispatcher and perform a point-in-triangle or point-in-tetra geometric predicate before adding a proximity to the needle-tissue coupling system.The new classes are:
Operation::ContainsInElementwhich uses theTriangleToolboxandTetrahedronToolboxto perform the check.Operation::ContainsInProximitywhich takes proximities as input and delegates to the one above.They can now be used by
InsertionAlgorithmas in:auto containsPointInVol = Operations::ContainsPointInProximity::Operation::get(l_volGeom->getTypeInfo());if(containsPointInVol(tipProx->getPosition(), volProx))Close #81