Additional promo variables

[TautvisStan]

• Promo variables: $territory#, $weight#, $height#

Summary by CodeRabbit

• New Features
  • Added support for three new dynamic variables in promotional content: territory, height, and weight. These variables expand the capabilities for creating personalized and dynamic promotional messages.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Three new variable substitutions were added to the promo script variable resolver in PromoPatch.cs: "territory", "height", and "weight", each mapping to specific attributes and methods from the MappedPromo collection, extending the dynamic replacement capabilities.

Changes

Cohort / File(s)	Summary
Promo variable substitutions Patches/PromoPatch.cs	Added three new variable mappings in ReplaceVars switch: "territory" → Atlas.name[MappedPromo.c[varIndex].home], "height" → MappedPromo.c[varIndex].DBAHDHJBCLN(), "weight" → MappedPromo.c[varIndex].LFEPPKMEOEM()

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Verify that the three new variable mappings correspond to the correct attributes/methods
• Confirm that the variable names ("territory", "height", "weight") are intentional and align with naming conventions
• Ensure no conflicts with existing variable substitutions

Poem

A rabbit hops through promo lines so bright,
Territory, height, and weight—what a delight!
Three new variables now dance and play,
Dynamic replacements light the way! 🐰✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Additional promo variables' directly and accurately reflects the main change: adding three new variable substitutions (territory, height, weight) to the promo script variable resolver.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 3ab8508 and 31844ea.

📒 Files selected for processing (1)

• Patches/PromoPatch.cs (1 hunks)

🔇 Additional comments (2)

Patches/PromoPatch.cs (2)

200-202: LGTM! New promo variables follow established patterns.

The three new variable substitutions are well-integrated into the existing switch expression and benefit from the surrounding error handling (try-catch block at lines 171-213).

---

200-200: Verify the nested array access for "territory".

The "territory" variable uses nested array access (Atlas.name[MappedPromo.c[varIndex].home]), which has more potential failure points than the direct property accesses used by other variables. While the try-catch block will handle any out-of-bounds errors gracefully, please verify at runtime that:

• MappedPromo.c[varIndex].home always returns valid indices for the Atlas.name array
• The "territory" variable produces the expected output in promo scripts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}