Graphic mode add access to buffered data#12
Open
TravisThomp wants to merge 1 commit intoIniterWorker:masterfrom
Open
Graphic mode add access to buffered data#12TravisThomp wants to merge 1 commit intoIniterWorker:masterfrom
TravisThomp wants to merge 1 commit intoIniterWorker:masterfrom
Conversation
Owner
let mut display_driver = Gc9a01::new(
interface,
DisplayResolution240x240,
DisplayRotation::Rotate180,
);
Let me know if you have more feedback about it. |
Author
|
Thanks, that makes more sense, especially for portability. I solved my issue by using embedded-graphics-framebuf and the driver in unbuffered mode. As for future considerations, would it be worth adding a get_pixel_at(x, y) method? It would resolve your concern about the unchecked method, but also provide some access to the data stored in the buffer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding direct access to the buffer to allow for easy manipulation. Convenient for applying filters.