Conversation
stignielsen-instech
left a comment
stignielsen-instech
left a comment
There was a problem hiding this comment.
The code comments are nit pick - but I think you need to extend the readme for this one based on your changes. A new paragraph explaining how you practically use this repository as a template (and also - we need to fix that when this code is merged). I created the explanation for this here: https://github.com/InsuranceTechnologySolutions/backend-coding-task?tab=readme-ov-file#read-this-first , you can probably reuse it as-is.
| @@ -0,0 +1,7 @@ | |||
| namespace AnchorageFiller.Clients.Responses; | |||
There was a problem hiding this comment.
You decide, but these are the DTOs used - and now you have 3 records in one class. They are lightweight, so that is ok'ish, but they could also each have their own file.
There was a problem hiding this comment.
Yeah, refactored into separate files now. And I was contemplating whether to move these models to a separate core/dto's project or not. But maybe it's best to leave that up to the candidate. (We can see if they decide to create their own models and mapping)
|
|
||
| public record GetFleetResponse(Size AnchorageSize, IReadOnlyList<FleetItem> Fleets); | ||
|
|
||
| public record FleetItem(Size SingleShipDimensions, string ShipDesignation, int ShipCount); |
There was a problem hiding this comment.
Dimension != Size - you use a new term for the same thing, SingleShipSize is cleaner imo.
2 participants
No description provided.