Skip to content

Modify: icMemDump change strncpy to memcpy, add comments #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xsscx merged 1 commit into from
Jan 5, 2026
Merged

Modify: icMemDump change strncpy to memcpy, add comments #444

xsscx merged 1 commit into from
Jan 5, 2026

Conversation

@ChrisCoxArt
Copy link
Contributor

@ChrisCoxArt ChrisCoxArt commented Jan 5, 2026

change strncpy to memcpy, and add comments that we are copying without NULLs
Fixes #441

Pull Request Checklist

  • Have you followed the guidelines in Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you built your Pull Request locally with the Build Instructions?
  • Have you added or updated relevant tests?
  • Have you added or updated relevant docs?

@ChrisCoxArt
Update IccUtil.cpp
4879571 
change strncpy to memcpy, and add comments that we are copying without NULLs
Fixes #441
@ChrisCoxArt ChrisCoxArt requested a review from xsscx as a code owner January 5, 2026 03:25
@xsscx xsscx self-assigned this Jan 5, 2026
@xsscx xsscx added PR Pull Request Review in Process PR being Reviewed by Maintainers labels Jan 5, 2026
xsscx
xsscx approved these changes Jan 5, 2026
View reviewed changes
Copy link
Member

@xsscx xsscx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mon Jan 5 03:27:44 AM UTC 2026

@xsscx xsscx changed the title icMemDump change strncpy to memcpy, add comments Modify: icMemDump change strncpy to memcpy, add comments Jan 5, 2026
@xsscx xsscx added Pending Merge Maintainer indicates Merge Pending and requests no further changes and removed Review in Process PR being Reviewed by Maintainers labels Jan 5, 2026
@xsscx xsscx merged commit 6188a0a into master Jan 5, 2026
23 checks passed
@xsscx xsscx added Merged Merged and removed Pending Merge Maintainer indicates Merge Pending and requests no further changes labels Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xsscx xsscx xsscx approved these changes

Assignees

@xsscx xsscx

Labels

Merged Merged PR Pull Request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SAST Report on function ‘void icMemDump(std::string&, void*, size_t)’:

3 participants

@ChrisCoxArt @xsscx