Skip to content

Conversation

@ChrisCoxArt
Copy link
Contributor

Add more detailed usage description.
Make pointer usage safer.
Fix inconsistent indention.
Make some variable names more descriptive.
Add additional safety to start/end/step inputs.
Add a few comments to explain what the code is doing.
Fixes #387

Pull Request Checklist

  • Have you followed the guidelines in Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you built your Pull Request locally with the Build Instructions?
  • Have you added or updated relevant tests?
  • Have you added or updated relevant docs?

Make pointer usage safer.
Fix inconsistent indention.
Make some variable names more descriptive.
Add additional safety to start/end/step inputs.
Add a few comments to explain what the code is doing.
Fixes #387
@ChrisCoxArt ChrisCoxArt requested a review from xsscx as a code owner January 5, 2026 03:32
@xsscx xsscx self-assigned this Jan 5, 2026
@xsscx xsscx added PR Pull Request Review in Process PR being Reviewed by Maintainers labels Jan 5, 2026
@xsscx xsscx changed the title add better usage description to iccSpecSepToTiff Add: Usage description to iccSpecSepToTiff Jan 5, 2026
Copy link
Member

@xsscx xsscx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mon Jan 5 03:48:34 AM UTC 2026

@xsscx xsscx added Pending Merge Maintainer indicates Merge Pending and requests no further changes and removed Review in Process PR being Reviewed by Maintainers labels Jan 5, 2026
@xsscx
Copy link
Member

xsscx commented Jan 5, 2026

PR Summary

Tools/IccSpecSepToTiff/iccSpecSepToTiff

Usage: iccSpecSepToTiff output compress sep infile_fmt start end incr {profile}
Concatenates several spectral TIFF files into a single file, with optional embedded ICC profile.
output: path/name of the TIFF file to be created
compress: boolean (0 | 1), should the output be compressed
sep: boolean (0 | 1), plane data be seperated in the output TIFF
infile_fmt: printf format string for input files, example: "spec_%06d.tiff"
start: integer, first channel number to process
end: integer, last channel number to process
increment: integer, increment between channels
profile: optional ICC profile to embed in the output TIFF

@xsscx xsscx merged commit 9408d93 into master Jan 5, 2026
23 checks passed
@xsscx xsscx added Merged Merged and removed Pending Merge Maintainer indicates Merge Pending and requests no further changes labels Jan 5, 2026
@xsscx xsscx changed the title Add: Usage description to iccSpecSepToTiff Add: Banner, usage description to iccSpecSepToTiff Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged Merged PR Pull Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TODO: Normalize iccSpecSepToTiff command-line help output

3 participants