-
Notifications
You must be signed in to change notification settings - Fork 27
Add toLedgerValidityInterval and fromLedgerValidityInterval #892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add toLedgerValidityInterval and fromLedgerValidityInterval #892
Conversation
631e761 to
e38b399
Compare
e38b399 to
e512b3a
Compare
|
This PR is stale because it has been open 45 days with no activity. |
|
This PR is stale because it has been open 45 days with no activity. |
| calculateExecutionUnitsLovelace prices eUnits = | ||
| return $ Alonzo.txscriptfee prices (toAlonzoExUnits eUnits) | ||
|
|
||
| toLedgerValidityInterval |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have those two functions here already: https://github.com/IntersectMBO/cardano-api/blob/master/cardano-api/src/Cardano/Api/Tx/Internal/Body.hs#L1667-L1667
Would it work for you to just export them instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah ha. Yes it would.
|
This PR is stale because it has been open 45 days with no activity. |
Changelog
Context
Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist