django.conf.urls.defaults and django.utils.simplejson are deprecated#16
Open
stefanocrosta wants to merge 2 commits intoInviteBox:masterfrom
Open
django.conf.urls.defaults and django.utils.simplejson are deprecated#16stefanocrosta wants to merge 2 commits intoInviteBox:masterfrom
stefanocrosta wants to merge 2 commits intoInviteBox:masterfrom
Conversation
Safely try importing django.conf.urls first, django.conf.urls.defaults later.
Try importing json first, safely fallback to simplejson. Please beware of some minor incompatibilities in particular with serialization: https://docs.djangoproject.com/en/dev/releases/1.5/#system-version-of-simplejson-no-longer-used
|
This would be very helpful if the pul were accepted. Thanks! |
|
It is a good thing to have, because django.conf.urls.defaults was removed in Django 1.6. |
|
Django 1.6 has been out for 5 months; can this be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both django.conf.urls.defaults and django.utils.simplejson are deprecated.
For backward compatibility, this safely try importing django.conf.urls first, fallback to django.conf.urls.defaults later.