Improve logging, shutdown handling, and environment validation#5
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| JWT_ACCESS_SECRET: z.string({required_error: "JWT_ACCESS_SECRET is required"}), | ||
|
|
||
| PORT: z.coerce.number().int().positive().default(3000), | ||
| SWAGGER_ENABLED: z.coerce.boolean().default(false), |
There was a problem hiding this comment.
The new env schema uses z.coerce.boolean() for SWAGGER_ENABLED (src/utils/environment-variables.ts) so any non-empty string parses to true; as shown by the .env.example value SWAGGER_ENABLED=false, this now always enables Swagger even when the flag is set to "false" or "0", exposing docs in environments where they were meant to be disabled.
Useful? React with 👍 / 👎.
IsaacHatilima
deleted the
codex/review-repository-and-suggest-changes
branch
1 participant
Summary
Testing
Codex Task