Conversation
…suggest-changes Improve logging, shutdown handling, and environment validation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
src/utils/environment-variables.ts
Outdated
| PORT: z.coerce.number().int().positive().default(3000), | ||
| SWAGGER_ENABLED: z.coerce.boolean().default(false), |
There was a problem hiding this comment.
SWAGGER_ENABLED env parser treats “false” as true
SWAGGER_ENABLED is coerced with z.coerce.boolean() (src/config/swagger.ts reads this at lines 7‑8), which means any non‑empty string—including the common setting SWAGGER_ENABLED=false shown in .env.example—parses to true. As a result Swagger docs will be enabled even when the flag is set to "false", unintentionally exposing API docs in environments that expect them to be off. The previous string comparison handled "false" correctly, so this is a regression.
Useful? React with 👍 / 👎.
No description provided.