Skip to content

review#6

Merged
IsaacHatilima merged 4 commits intomasterfrom
review
Dec 25, 2025
Merged

review#6
IsaacHatilima merged 4 commits intomasterfrom
review

Conversation

@IsaacHatilima
Copy link
Owner

No description provided.

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 40 to 41
PORT: z.coerce.number().int().positive().default(3000),
SWAGGER_ENABLED: z.coerce.boolean().default(false),

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge SWAGGER_ENABLED env parser treats “false” as true

SWAGGER_ENABLED is coerced with z.coerce.boolean() (src/config/swagger.ts reads this at lines 7‑8), which means any non‑empty string—including the common setting SWAGGER_ENABLED=false shown in .env.example—parses to true. As a result Swagger docs will be enabled even when the flag is set to "false", unintentionally exposing API docs in environments that expect them to be off. The previous string comparison handled "false" correctly, so this is a regression.

Useful? React with 👍 / 👎.

@IsaacHatilima IsaacHatilima merged commit 357222d into master Dec 25, 2025
1 check passed
@IsaacHatilima IsaacHatilima deleted the review branch December 25, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant