Skip to content

Avoid double increment #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jmcclelland wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Avoid double increment #3

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c271f30
don't double count requests in same conn
jmcclelland Oct 11, 2025
e6537df
deferring connections should be a warning
jmcclelland Oct 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions mod_vhost_limit.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,18 +129,23 @@ static int handle_r(request_rec *r)

if (data->counter >= conf->max_clients)
{
ap_log_error(APLOG_MARK, APLOG_INFO, 0,NULL,"%s: Access to %s deferred, Max Clients %d exceeded (%d currently)",MOD_NAME, conf->name, conf->max_clients, data->counter);
ap_log_error(APLOG_MARK, APLOG_WARNING, 0,NULL,"%s: Access to %s deferred, Max Clients %d exceeded (%d currently)",MOD_NAME, conf->name, conf->max_clients, data->counter);
return HTTP_SERVICE_UNAVAILABLE;
}

char *s = (char*) apr_pcalloc(pool, sizeof(char)*8);
apr_snprintf(s,8,"%d",conf->sid);
apr_table_t *table = r->connection->notes;
apr_table_setn(table,"sid", s );

apr_atomic_add32(&data->counter,1);

ap_log_error(APLOG_MARK,APLOG_DEBUG|APLOG_NOERRNO, 0 ,NULL, "%s: handling IN %s (%s) = %d", MOD_NAME, conf->name, s, data->counter);
const char *existing_sid = apr_table_get(table, "sid");
if (existing_sid == NULL) {
apr_table_setn(table,"sid", s );
apr_atomic_add32(&data->counter,1);
ap_log_error(APLOG_MARK,APLOG_DEBUG|APLOG_NOERRNO, 0 ,NULL, "%s: handling IN %s (%s) = %d", MOD_NAME, conf->name, s, data->counter);
}
else {
ap_log_error(APLOG_MARK,APLOG_DEBUG|APLOG_NOERRNO, 0 ,NULL, "%s: sid already exists = %d", MOD_NAME, conf->name, s);
}

return DECLINED;
}
Expand Down