Update crtm-fix: link little endian and test files; run more tests for crtm and ufo; update NRL batch install to run tests#1928
Open
climbfuji wants to merge 64 commits intoJCSDA:developfrom
Conversation
.gitmodules and submodule pointer for spack for code review and testing
…g,gcc,oneapi}.yaml; remove outdated packages yaamls for aocc, apple-clang, intel classic
…eature/update_spack-stack-dev_from_develop
…/ubuntu-ci-x86_64-oneapi.cfg and .github/workflows/ubuntu-ci-x86_64-oneapi-ifx.cfg
…es.yaml to avoid duplicate packages
…o prevent build errors with gcc when generator=ninja
…hod to determine preferred compiler
…eview and testing
…eature/update_spack-stack-dev_from_develop
… for external openmpi
… spack-stack repo; add as variant to jedi-neptune-env and enable variant in neptune-dev environment template
…/github.com/climbfuji/spack-stack into feature/update_spack-stack-dev_from_develop
…eature/jedi_components
…compiler requirements; set mkl variant for oops
…ne_env/package.py
…converters/package.py to install missing scripts
…eview and testing
…i/spack-stack into bugfix/crtm_fix_link_little_endian
…ugfix/crtm_fix_link_little_endian
…ugfix/crtm_fix_link_little_endian
…ugfix/crtm_fix_link_little_endian
climbfuji
commented
Mar 3, 2026
climbfuji
changed the title
climbfuji
requested review from
ADCollard,
AlexanderRichert-NOAA,
BenjaminTJohnson,
DavidHuber-NOAA and
eap
climbfuji
commented
Mar 4, 2026
| "ufo_test_tier1_test_ufo_ssmis_f17_gfs_backgroundcheck_nbc", | ||
| ] | ||
| # Additional test failures with Intel oneAPI only | ||
| skipped_tests = [] |
Collaborator
Author
There was a problem hiding this comment.
That means that with gcc, all tests pass!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is for develop, not for
release/2.1.This PR does the following:
crtm-fixandcrtmpackages inrepos/builtin- see Remove crtm-fix/crtm 2.3.0_emc; fix directory structure of crtm-fix files (create symbolic links for backward compatibility) spack-packages#43.crtm-fixto be linked to the top-level directory.crtmandufo(there are still many Intel oneAPI test failures forufo, but these will be addressed once we move to a newer tag ofufoafter JCSDA finished their spack-stack-2.x.y code sprints).These changes are motivated by the discussions in issues #1910 and #1914.
Dependencies
Issues addressed
Closes #1910
Closes #1914
Applications affected
UFS, NEPTUNE
Systems affected
None
Testing
gccandoneapion @climbfuji's dev box - this is with running the tests using the new-tflag for the NRL batch install script.-tflag. This is because some of the ctests require an allocation on a compute node and an appropriately configured parallel launcher, which is beyond the scope of this pull request.Checklist
All necessary updates to the documentation (spack-stack wiki) will be made when this PR is merged