refactor: 여행, 스탬프, 미션 조회 비즈니스 로직에 완료 여부 검증 정책 추가(#116) #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor: TripQueryService.getValidTrip()에 완료 여부 검증 정책 추가 * refactor: StampQueryService.getValidStamp()에 완료 여부 검증 정책 추가 * refactor: MissionQueryService.getValidMission()에 완료 여부 검증 정책 추가 * refactor: MemberFacade.confirmImage()에 멤버 캐시 무효화 로직 추가 * refactor: StudyLogFacade.confirmImage()에 학습 로그 캐시 무효화 로직 추가 * test: TripQueryServiceTest에서 GetValidTrip 단위 테스트 수정 * test: StampQueryServiceTest에서 GetValidStamp 단위 테스트 수정 * test: MissionQueryServiceTest에서 GetValidMission 단위 테스트 수정
chaiminwoo0223
changed the title
chaiminwoo0223
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 작업 내용 및 특이사항
✅ 검증 조회 비즈니스 로직에 완료 여부 검증 정책 추가
TripQueryService.getValidTrip()에TripPolicy.validateCompleted()추가StampQueryService.getValidStamp()에StampPolicy.validateCompleted()추가MissionQueryService.getValidMission()에MissionPolicy.validateCompleted()추가✅ 테스트
TripQueryServiceTest에서GetValidTrip단위 테스트 수정StampQueryServiceTest에서GetValidStamp단위 테스트 수정MissionQueryServiceTest에서GetValidMission단위 테스트 수정🌱 관련 이슈
🔍 참고사항(선택)
MemberFacade.confirmImage()에 멤버 캐시 무효화 로직 추가 -> MEMBERStudyLogFacade.confirmImage()에 학습 로그 캐시 무효화 로직 추가 -> STUDYLOGS📚 기타(선택)