Enable client to set a custom animation type. #32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As a client of the SDK I need to be able to set a custom animation type.
The animation currently defaults to
spring()which takes a bit to long to complete. I added to possibility to override the default behavior with a Animation injected through a closure.Technical decisions
Animation is injected through a closure allowing the client to perform run time logic. Animation closure is optional in initializer so the changes would not be breaking for existing clients. Current default behavior is maintained.
Call site exemple