Skip to content

Conversation

@jlarmstrongiv
Copy link

@JackHowa
Copy link
Owner

hi @jlarmstrongiv ! I want to make sure this will still work as expected for the package users; are there test steps that you're working off of? happy to test this out locally

Copy link
Owner

@JackHowa JackHowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like some of the tests fail. Let me know if you have time for this? I want to make sure this change is safe moving forward to react 17

lib/__tests__/index.test.js
    with children
      ✓ renders children (30 ms)
    with no children
      ✓ renders null (4 ms)
  ActionCableConsumer
    wrapped with ForwardRef
      ✓ renders the ForwardRef (6 ms)
      ✕ renders the consumer (126 ms)
      ✕ renders the controller (11 ms)
  ActionCableController
    with cable passed to provider
      ✕ passes cable to the controller as a prop (5 ms)
      with children
        ✕ renders children (7 ms)
      without children
        ✕ renders null (7 ms)

@JackHowa JackHowa added bug Something isn't working help wanted Extra attention is needed and removed Hacktoberfest labels Sep 29, 2021
@JackHowa JackHowa changed the base branch from master to main December 21, 2021 17:54
@JackHowa
Copy link
Owner

Didn't hear back on this; may be breaking change

@JackHowa JackHowa closed this Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working help wanted Extra attention is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants