Expand support of no-missing-element-type-definition rule#108
Merged
JackRobards merged 1 commit intomainfrom Jan 20, 2025
Merged
Expand support of no-missing-element-type-definition rule#108JackRobards merged 1 commit intomainfrom
JackRobards merged 1 commit intomainfrom
Conversation
… with no-missing-element-type-definition rule
🦋 Changeset detectedLatest commit: f84df34 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JackRobards
changed the title
JackRobards
changed the title
JackRobards
deleted the
missing-element-type-definition-class-properties
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea is to make sure this change supports both static class properties, and also variables
Not a change I made, it is taken from these two PRs:
runem/web-component-analyzer#279
runem#331
Thank you to the original author!
I added a test for the variable case, which I am hoping to also solve in this PR.