Exclude imports with type-only bindings from list of dependencies to visit#111
Merged
JackRobards merged 1 commit intomainfrom Jan 25, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: 4322ba8 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Owner
Author
|
One of the other test cases caught a potential regression here. Hopefully shouldn't be too hard to fix! |
JackRobards
force-pushed
the
ignore-type-only-imports-in-dependencies
branch
from
910acb0 to
4322ba8
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not a change I made, it is taken from this PR:
runem#372
Not a lot of context in that PR, but I confirmed that the added test failed without this addition. It seems like a good case to handle to me.
Thank you to the original author!