v10.1.1: fix import/export operations on iOS #180
Merged
JaffaKetchup merged 5 commits intomainfrom Mar 9, 2025
Merged
Conversation
Improved efficiency of import operation
Owner
Author
|
The problem is that using manual chunking seems to grow the database rapidly for some reason, and uses considerably more memory, whereas streaming seems to be slightly slower, but uses much less memory and does not appear to grow the database at all. Unfortunately, the growth caused by the chunking is quite significant (it seems to be the entire amount of the import stores' tiles), and that might make this unsuitable for production, especially as it cannot be shrunk afterward. EDIT: I've reduced the memory growth rate significantly by using more transactions - whilst this does mean potentially slightly reduced performance, it appears not to be noticable. This also resolved the size growth of the database file. |
Remove unneccessary check on each iteration in `chunked`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #178.