Skip to content

Fix effects running on reconnect anyways #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JamesHutchison wants to merge 2 commits into
base: fix-checkbox-missing-checked
Choose a base branch
from
Open

Fix effects running on reconnect anyways #16

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
908b066
Fix effects running on reconnect anyways
JamesHutchison May 3, 2024
662f8a7
fix
JamesHutchison May 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions src/py/reactpy/reactpy/core/hooks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,9 @@ class ReconnectingOnly(list):


@overload
def use_state(initial_value: Callable[[], _Type], *, server_only: bool = False) -> State[_Type]: ...
def use_state(
initial_value: Callable[[], _Type], *, server_only: bool = False
) -> State[_Type]: ...


@overload
Expand Down Expand Up @@ -190,12 +192,9 @@ def use_effect(
hook = get_current_hook()
if hook.reconnecting.current:
if not isinstance(dependencies, ReconnectingOnly):
return
dependencies = None
else:
if isinstance(dependencies, ReconnectingOnly):
return
dependencies = _try_to_infer_closure_values(function, dependencies)
return memoize(lambda: None)
elif isinstance(dependencies, ReconnectingOnly):
return

def add_effect(function: _EffectApplyFunc) -> None:
if not asyncio.iscoroutinefunction(function):
Expand Down