Conversation
rhayes777
approved these changes
Feb 21, 2025
autoarray/plot/multi_plotters.py
Outdated
Comment on lines
+264
to
+272
| if self.plotter_list[0].mat_plot_1d is not None: | ||
| self.plotter_list[0].mat_plot_1d.output.subplot_to_figure( | ||
| auto_filename=f"subplot_{filename_suffix}" | ||
| ) | ||
| if self.plotter_list[0].mat_plot_2d is not None: | ||
| self.plotter_list[0].mat_plot_2d.output.subplot_to_figure( | ||
| auto_filename=f"subplot_{filename_suffix}" | ||
| ) | ||
| self.plotter_list[0].close_subplot_figure() |
Collaborator
There was a problem hiding this comment.
Assign variables to avoid repetition
autoarray/plot/multi_plotters.py
Outdated
Comment on lines
+319
to
+322
| output_fits_file = os.path.join(output_path, f"{filename}.fits") | ||
|
|
||
| if remove_fits_first and os.path.exists(output_fits_file): | ||
| os.remove(output_fits_file) |
Collaborator
There was a problem hiding this comment.
It's much nicer to use pathlib.Path
Comment on lines
+900
to
+904
| try: | ||
| header["PIXSCAY"] = str(arr.pixel_scales[0]) | ||
| header["PIXSCAX"] = str(arr.pixel_scales[1]) | ||
| except AttributeError: | ||
| pass |
Collaborator
There was a problem hiding this comment.
y, x = map(str, arr.pixel_scales)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors image output such that:
Removes config customization on the level of individual figures, as this made configs too complex and can be achieved via
AggretorImages.Outputs .fits files containing key images as .fits output of key information is key, with these grouped packages suited to
AggregatorFitsobject.Creates a nasty new function in
MultiFigurePlotterfor outputting .fits groups viaPlotterinterface, quite hacky but works for now.