Skip to content

Feature/jax only triangles #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jammy2211 merged 13 commits into from
Jun 18, 2025
Merged

Feature/jax only triangles #176

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
09784fa
removed numpy based Trianghle and fixed first test
Jun 17, 2025
3f24384
fix one_triangle.triangles
Jun 17, 2025
2db16d9
test__above
Jun 17, 2025
81d1c70
multiple fixes in test_coordinate_implementation.py
Jun 17, 2025
6c35ed2
remove containment test
Jun 17, 2025
075e8e7
test_array_representation deleted
Jun 17, 2025
3933b55
fix test_extended_source
Jun 17, 2025
20ceaca
JAx CoordinateArrayTriangles has explicit JAX use now
Jun 17, 2025
d83f4ba
simplfiied coordinate_array and removed support for numpy
Jun 17, 2025
1094154
refactor arrayu to only use JAX
Jun 17, 2025
b4f1853
simplify unit tests
Jun 17, 2025
33eb087
black
Jun 17, 2025
ad4211e
black
Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions autoarray/structures/triangles/abstract.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
import numpy as np

from autoarray import Grid2D
from autoarray.structures.triangles.shape import Shape

HEIGHT_FACTOR = 3**0.5 / 2

Expand Down Expand Up @@ -122,21 +121,6 @@ def for_indexes(self, indexes: np.ndarray) -> "AbstractTriangles":
The new ArrayTriangles instance.
"""

@abstractmethod
def containing_indices(self, shape: Shape) -> np.ndarray:
"""
Find the triangles that insect with a given shape.

Parameters
----------
shape
The shape

Returns
-------
The indices of triangles that intersect the shape.
"""

@abstractmethod
def neighborhood(self) -> "AbstractTriangles":
"""
Expand Down
Loading
Loading