Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
image_meshrefers to the image-plane grid of (y,x) coordinates which form the source pixel centres of an adaptive source mesh in the source-plane, for example the vertexes of a Delaunay triangulation or centres of Voronoi cells.The
image_meshwas previously implemented inside thePixelizationobject, whereby a newimage_meshwas made based on parameters which could be fitted for by a search.Such an approach is not feasible by JAX, and has proven ill posed on occations, therefore this PR makes the image mesh grid something which is computed pre modeling (using the same
Overlay/Hilbertobjects as before) and passed through the modeling via theAdaptImages.The
AdaptImagesare now also explicitly set up during a pipeline by a user.