Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hate my life...
Fixes an input to
relocated_mesh_grid_from, which previously input an over sampled grid when the relocation assumed a non-oversampled grid. This bug lost me a few days, as shocking the nearest neighbor border relocation I removed did not care about this bug... but the ellipse tracing does.Mesh grid handling:
autoarray/inversion/pixelization/mesh/delaunay.py, updated themapper_grids_frommethod to use the providedsource_plane_data_griddirectly instead of creating a newGrid2DIrregularfrom the relocated grid, ensuring more accurate and consistent grid mapping.Voronoi area computation:
autoarray/structures/mesh/delaunay_2d.py, removed the exception handling fallback for Voronoi area calculation inscipy_delaunay, so Voronoi areas are now always computed directly without falling back to barycentric areas in case of errors. This streamlines the area calculation process and removes unnecessary error handling.…rids