Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR performs small formatting-only cleanups to improve readability/consistency in the imaging simulator and to remove extra blank lines in a geometry util test.
Changes:
- Reformats
Kernel2Dconvolution calls inSimulatorImaging.via_image_from()for improved readability. - Removes redundant blank lines in
test_geometry_util.py.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
autoarray/dataset/imaging/simulator.py |
Re-wraps PSF convolution calls into multi-line formatting. |
test_autoarray/geometry/test_geometry_util.py |
Removes unnecessary blank lines between tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
139
to
+148
| if self.use_real_space_convolution: | ||
| image = self.psf.convolved_image_via_real_space_from( | ||
| image=image, blurring_image=None, xp=xp, | ||
| image=image, | ||
| blurring_image=None, | ||
| xp=xp, | ||
| ) | ||
| else: | ||
| image = self.psf.convolved_image_from(image=image, blurring_image=None, xp=xp) | ||
| image = self.psf.convolved_image_from( | ||
| image=image, blurring_image=None, xp=xp | ||
| ) |
There was a problem hiding this comment.
The PR title suggests a division-by-zero bug fix ("ell_comps_division_0_bug_fix"), but the changes in this PR appear to be formatting-only (argument wrapping / whitespace). Please align the title/description with the actual changes, or include the intended bug fix in this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request mainly consists of minor code cleanups for improved readability and consistency. The changes include reformatting function calls for better clarity and removing unnecessary blank lines in test files.
Code formatting improvements:
convolved_image_via_real_space_fromandconvolved_image_frominautoarray/dataset/imaging/simulator.pyto use multi-line arguments, improving readability.Test file cleanup:
test_autoarray/geometry/test_geometry_util.pyto maintain consistent formatting.