Skip to content

refactor: split mask tests into granular focused tests #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jammy2211 merged 1 commit into from
Mar 10, 2026
Merged

refactor: split mask tests into granular focused tests #232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 32 additions & 30 deletions test_autoarray/mask/test_mask_1d.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,12 @@
)


def test__constructor():
# ---------------------------------------------------------------------------
# constructor
# ---------------------------------------------------------------------------


def test__constructor__2_element_mask__pixel_scale_and_extent_correct():
mask = aa.Mask1D(mask=[False, True], pixel_scales=1.0)

assert type(mask) == aa.Mask1D
Expand All @@ -20,6 +25,8 @@ def test__constructor():
assert mask.origin == (0.0,)
assert (mask.geometry.extent == np.array([-1.0, 1.0])).all()


def test__constructor__3_element_mask_with_origin__pixel_scale_origin_and_extent_correct():
mask = aa.Mask1D(mask=[False, False, True], pixel_scales=3.0, origin=(1.0,))

assert type(mask) == aa.Mask1D
Expand All @@ -28,6 +35,8 @@ def test__constructor():
assert mask.origin == (1.0,)
assert (mask.geometry.extent == np.array([-3.5, 5.5])).all()


def test__constructor__4_element_mask_with_origin__pixel_scale_and_origin_correct():
mask = aa.Mask1D(mask=[False, False, True, True], pixel_scales=3.0, origin=(1.0,))

assert type(mask) == aa.Mask1D
Expand All @@ -36,7 +45,7 @@ def test__constructor():
assert mask.origin == (1.0,)


def test__constructor__invert_is_true():
def test__constructor__invert_true__boolean_values_inverted():
mask = aa.Mask1D(mask=[True, True, False], pixel_scales=1.0, invert=True)

assert type(mask) == aa.Mask1D
Expand All @@ -48,37 +57,30 @@ def test__constructor__input_is_2d_mask__raises_exception():
aa.Mask1D(mask=[[False, False, True]], pixel_scales=1.0)


def test__is_all_true():
mask = aa.Mask1D(mask=[False, False, False, False], pixel_scales=1.0)

assert mask.is_all_true == False

mask = aa.Mask1D(mask=[False, False], pixel_scales=1.0)

assert mask.is_all_true == False

mask = aa.Mask1D(mask=[False, True, False, False], pixel_scales=1.0)

assert mask.is_all_true == False

mask = aa.Mask1D(mask=[True, True, True, True], pixel_scales=1.0)

assert mask.is_all_true == True


def test__is_all_false():
mask = aa.Mask1D(mask=[False, False, False, False], pixel_scales=1.0)

assert mask.is_all_false == True
# ---------------------------------------------------------------------------
# is_all_true / is_all_false — parametrized
# ---------------------------------------------------------------------------

mask = aa.Mask1D(mask=[False, False], pixel_scales=1.0)

assert mask.is_all_false == True
@pytest.mark.parametrize("mask_values,expected", [
([False, False, False, False], False),
([False, False], False),
([False, True, False, False], False),
([True, True, True, True], True),
])
def test__is_all_true__various_masks__returns_correct_boolean(mask_values, expected):
mask = aa.Mask1D(mask=mask_values, pixel_scales=1.0)

mask = aa.Mask1D(mask=[False, True, False, False], pixel_scales=1.0)
assert mask.is_all_true == expected

assert mask.is_all_false == False

mask = aa.Mask1D(mask=[True, True, False, False], pixel_scales=1.0)
@pytest.mark.parametrize("mask_values,expected", [
([False, False, False, False], True),
([False, False], True),
([False, True, False, False], False),
([True, True, False, False], False),
])
def test__is_all_false__various_masks__returns_correct_boolean(mask_values, expected):
mask = aa.Mask1D(mask=mask_values, pixel_scales=1.0)

assert mask.is_all_false == False
assert mask.is_all_false == expected
Loading
Loading