Skip to content

Fix: TypeError: Unicode-objects must be encoded before hashing #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jagu-sayan wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix: TypeError: Unicode-objects must be encoded before hashing #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b8c9386
fix string passed to hashlib need to be encoded
jagu-sayan Jul 11, 2016
79074b4
fix wrong import
jagu-sayan Jul 11, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions onesky/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ def create_auth_variables(self):
timestamp = str(int(time.time()))

dev_hash = hashlib.md5()
dev_hash.update(timestamp)
dev_hash.update(self.api_secret)
dev_hash.update(timestamp.encode('utf-8'))
dev_hash.update(self.api_secret.encode('utf-8'))

return {
'api_key': self.api_key,
Expand Down
2 changes: 1 addition & 1 deletion onesky/interactive.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import urllib
import sys

import client
from onesky import client


# helper to simplify the boilerplate wrapping all the API calls with command
Expand Down