Fix manifest pack name and version parsing in skin pack export#861
Open
nchiari wants to merge 1 commit intoJannisX11:masterfrom
Open
Fix manifest pack name and version parsing in skin pack export#861nchiari wants to merge 1 commit intoJannisX11:masterfrom
nchiari wants to merge 1 commit intoJannisX11:masterfrom
Conversation
- Use the user-provided Pack Name in manifest.json (header.name) instead of the hardcoded "pack.name". - Normalize exported manifest version to a numeric 3-part array ([major, minor, patch]). - Accept flexible version input formats (e.g. 1, 1.0, 1.0.0, mixed text) and safely parse them into [x, y, z]. - Fix export dialog default value for Version to use FormValues.version (instead of FormValues.uuid).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.