Port the codebase to 1.21.1 #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjarduk
commented
Sep 29, 2025
Collaborator
Author
mjarduk
left a comment
mjarduk
left a comment
There was a problem hiding this comment.
Its alright, however I'm pretty sure we can move the API stuff into the common module as well. For what it's worth it's not large enough to be split into its own thing. Just move the service declarations and the services into the common module and we should be fine.
Collaborator
Author
|
Also, you're using an outdated version of the shadow plugin. I advise using the new builds published by GradleUp, to whom the plugin was transferred |
…sException is caught, because that doesn't hamper the mod's operations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch ports the mod's problematic classes to 1.21.1, as well as making slight changes to the build system. I'll review them later (sounds weird because I'm reviewing a maintainers commits)