Skip to content

Conversation

@nathanwbrei
Copy link
Collaborator

Behavior change

  • Remove CallbackStyle::DeclarativeMode: This was originally added to be consistent with JOmniFactory, but never used. The callback style suffers from several problems:
    1. The name clashes with JOmniFactory::ChangeRun. Now that JOmniFactory inherits from JFactory, this causes warnings about a non-virtual method overriding a virtual one.
    2. The arguments are ambiguous, causing user confusion and clang-tidy complaints
    3. It won't generalize to multi-level topologies, compared to JEvent::GetParent.

Bugfixes

  • Fix memory leaks relating to JDatabundle upcast functions
  • Fix bug in JOutput::EulerianStore due to JLightweightDatabundle copy constructor
  • Unit test suite passes LeakSanitizer for the first time

Refactoring

  • JOmniFactory inherits from JFactory
  • JWiringService is substantially more testable

@nathanwbrei nathanwbrei force-pushed the nbrei_even_more_wiring branch from e79d5a5 to cd7818c Compare October 16, 2025 02:39
@nathanwbrei nathanwbrei merged commit 52da95c into master Oct 16, 2025
16 checks passed
@nathanwbrei nathanwbrei deleted the nbrei_even_more_wiring branch October 16, 2025 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants