Skip to content

java 21 #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
baltzell wants to merge 5 commits into from
Closed

java 21 #315

baltzell wants to merge 5 commits into from

Conversation

@baltzell
Copy link
Collaborator

@baltzell baltzell commented Aug 21, 2024

No description provided.

@baltzell baltzell force-pushed the java21 branch 4 times, most recently from 8ec04d5 to 13c3389 Compare August 26, 2024 17:19
This was referenced Sep 24, 2024
Closed
Closed
This was referenced Oct 7, 2024
Closed
Closed
This was referenced Nov 4, 2024
Closed
Closed
@baltzell baltzell marked this pull request as ready for review November 6, 2024 02:41
This was referenced Dec 9, 2024
Closed
Closed
c-dilks
c-dilks reviewed Dec 16, 2024
View reviewed changes
@c-dilks
Copy link
Member

c-dilks commented Dec 16, 2024

ignore validation pipeline failure, since JeffersonLab/clas12-validation#163 is needed.

@c-dilks
Copy link
Member

c-dilks commented Dec 17, 2024

When you're ready to merge this, let's also merge

@baltzell
Copy link
Collaborator Author

baltzell commented Dec 18, 2024 •
edited
Loading

I don't think either of those (JeffersonLab/clas12-timeline#236, JeffersonLab/clas12-validation#163) really need to wait for this. In some ways, it's better if they go ahead.

@c-dilks
Copy link
Member

c-dilks commented Dec 18, 2024

added to java21 project page: https://github.com/orgs/JeffersonLab/projects/45/views/1

c-dilks
c-dilks reviewed Dec 19, 2024
View reviewed changes
Copy link
Member

@c-dilks c-dilks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might as well bump these to the latest version that @dependabot proposed

@baltzell baltzell marked this pull request as draft January 6, 2025 19:27
@baltzell baltzell force-pushed the java21 branch 2 times, most recently from 0e666d4 to bb1edc9 Compare January 6, 2025 19:55
@baltzell baltzell marked this pull request as ready for review May 31, 2025 00:16
c-dilks
c-dilks previously approved these changes May 31, 2025
View reviewed changes
@c-dilks c-dilks self-requested a review September 3, 2025 20:59
c-dilks
c-dilks requested changes Sep 3, 2025
View reviewed changes
Copy link
Member

@c-dilks c-dilks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also bump the release parameter:

coatjava/pom.xml

Lines 247 to 255 in 416c3a3

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.14.0</version>
<configuration>
<release>17</release>
<encoding>UTF-8</encoding>
</configuration>
</plugin>

@baltzell baltzell closed this Sep 3, 2025
@baltzell baltzell deleted the java21 branch September 3, 2025 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@c-dilks c-dilks c-dilks requested changes

@raffaelladevita raffaelladevita Awaiting requested review from raffaelladevita raffaelladevita is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@baltzell @c-dilks